Brian Thorne

Replace low level database operations with an ORM

2

I quite like the look of [peewee](http://peewee.readthedocs.io/en/latest/index.html) although SqlAlchemy is the standard. For example we would define `models` for our tables: ``` class Project(BaseModel): access_token = pw.TextField() chunk_size = pw.BigIntegerField(constraints=[pw.SQL("DEFAULT...

This service doesn't provide an api for client side filter of p-sig blocks, rather all candidate blocks are uploaded and the server [joins by block name](https://github.com/data61/anonlink-entity-service/blob/1b4a89ba2f639971eb8cf4288c45955a443d9d9b/backend/entityservice/tasks/comparing.py#L182). See the [blocklib tutorial](https://blocklib.readthedocs.io/en/latest/tutorial/tutorial_blocking.html#Generate-Final-Blocks)...

Handle blocking input that doesn't cover all encodings

1

`blocklib` filters out records according to the blocking specification. It warns if all records are not included in a block after using a particular blocking schema, but as someone else...

Improve opentracing

5

Misc issues when trialing jaeger tracing. 1) I've seen the warning "invalid parent span" for the following tasks at various times (not always): - `entityservice.tasks.solver.solver_task`, - `entityservice.tasks.mark_run_complete.mark_run_complete` and - `entityservice.tasks.run.prerun_check`...

Add Container Diagrams to docs

2

We should have a high level architecture diagram showing the communication between the various containers.

Create smaller docker images using multi-stage build

3

Instead of including gcc and everything required to compile all our dependencies we could probably build a smaller image which would have a smaller attack surface. https://docs.docker.com/develop/develop-images/multistage-build/#before-multi-stage-builds

Configuration of structlog output in logging file

1

See https://github.com/n1analytics/entity-service/pull/349#discussion_r273343179

The outputs types permutation and similarity scores only work for 2 parties at the moment.

Document logging

1

See https://docs.protari.d61.io/dev/setting-up/logging/#example-logging

REST api should handle malformed input better

1

If we are a misbehaving user do we get good error messages back from the rest api.