dash
dash copied to clipboard
FESTIVE stateful bitrate update misunderstanding
Dear authors and to whom it may concern,
I have been using this project for my research and I'd like to thank the authors for such a great contribution.
However, I have checked the FESTIVE algorithm and found out that there was a part in your FESTIVE.cc file that might have been misunderstood.
https://github.com/haraldott/dash/blob/3522e46109134688e9e1ba3769f0a055c971add9/model/festive.cc#L39 https://github.com/haraldott/dash/blob/3522e46109134688e9e1ba3769f0a055c971add9/model/festive.cc#L122-L147
According to the white paper of FESTIVE, bitrate at level k
will remain the same for at least k
chunks, before switching up to level k+1
. Also in their paper, they've given an example where bitrate at 1130Kbps would switch up after 5 chunks, which I think might have led to this misunderstanding.
Therefore, the comparisons at line #130 and #140 should be if (count >= currentRepIndex)
, instead of the fixed value of 5.
Hope it helps.
i think the original code is right ,count represents steps