MEDIUM: config: add disable-ingress-status-update configuration flag
This PR introduces a new controller configuration flag. When enabled, this flag prevents the controller from updating the status field of Ingress resources. By default, status updates remain enabled.
New flag:
--disable-ingress-status-update (boolean, default: false)
When set, the controller will skip updating the LoadBalancer status field in managed Ingress resources. Useful for scenarios where another controller or external process manages Ingress status, or when status updates are not desired. It won't set status field and it will be just empty:
$ k get ingress test-ingress-99999 -o jsonpath='{.status}' | jq . -r
{
"loadBalancer": {}
}
Code changes:
- Added the DisableIngressStatusUpdate field to the configuration struct.
- Passed the flag through the controller and status update logic.
- Updated the UpdateStatus method to respect the flag.
- Updated documentation
The flag is now listed in the arguments table and has a dedicated section describing its usage and example. If the flag is not specified, status updates are enabled by default.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This is certainly a feature, I'm interested in!
hi @vriabyk
everything seems fine, except commit messages, it should be just one commit :
MEDIUM: config: add disable-ingress-status-update configuration flag
we have two options:
-
you squash them and push the changes.
-
I can squash it if you you are Ok with, but I can't do it on Github (but interrnaly) due to our policy, so I can push that changes and then close this PR (is basically same effect). It will still be your contribution, so no real difference.
Hi @oktalz , second option works fine for me :) please do it, thank you!