python-orvibo icon indicating copy to clipboard operation
python-orvibo copied to clipboard

Python 2 support?

Open guysoft opened this issue 8 years ago • 1 comments

Hey, So I know its in the docs, but was wondering if there is a way to get Python 2 support? What needs to be done to support python2?

guysoft avatar Feb 11 '17 17:02 guysoft

https://github.com/happyleavesaoc/python-orvibo/blob/master/orvibo/s20.py#L57 Replace by: udp = threading.Thread(target=_listen) (daemon param is not allowed in Py2)

https://github.com/happyleavesaoc/python-orvibo/blob/master/orvibo/s20.py#L273 Replace by: def _udp_transact(self, payload, handler, broadcast=False, timeout=TIMEOUT, *args): Py2 only accepts possitional arguments at the end.

plutec avatar Jun 06 '17 09:06 plutec