ld-decode icon indicating copy to clipboard operation
ld-decode copied to clipboard

Detailed value readout in ld-analyse GUI

Open Zcooger opened this issue 4 years ago • 4 comments

This ticket is intended to suggest adding more controls for the TBC review such as IRE adjustment in waveform monitor and active video start/end range (cropping black borders). In case of using manual adjust original values would be still kept in .json file and overridden values used instead by the decoder.

Zcooger avatar Nov 23 '20 17:11 Zcooger

A slider for white16bIre and black16bIre would be handy, and ld-chroma-decoder should also accept the overrides as options. Another useful tool would be eyedropper-type things to set them based on selected sample points.

I've been meaning to suggest this once #305 is implemented.

Gamnn avatar Nov 24 '20 01:11 Gamnn

So far ld-analyse has been designed as a 'read only' tool for analysing the output of other tools. I'm not convinced that it has the right 'structure' for actually editing TBC and metadata files (I found this out when trying to implement the ability to edit VBI data... it's a can of worms).

Adding a couple of sliders to modify the output of the ld-analyse viewer is possible though (and more in-line with the application's intent). This will not update the metadata.

If that's an acceptable solution, let me know and I will modify this issue accordingly.

simoninns avatar Nov 29 '20 08:11 simoninns

Sorry wrong button :)

simoninns avatar Nov 29 '20 08:11 simoninns

Keeping viewer app read-only is fine if we don't want worms to spread out. Then I'd change the approach of the issue to "Detailed value readout in ld-analyse". User will be responsible for keeping original .json if he wants to modify disc/tape properties in external editor. These readouts would be:

  • Current .json values of white16bIre, black16bIre, burst range and active video range.
  • Cursor coordinates in waveform monitor (horizontal pixel # and 16b value).
  • Cursor coordinates in TBC display (horizontal pixel #, vertical pixel #, 16b Y value of TBC and 16b/8b RGB value of chroma decoder output if comb is enabled).
  • Video luminance lines in waveform monitor for limited (0-255) and full (16-235) 8b range (one of them is currently used as analog black level and it's probably mapped to limited range in postprocessing).

I hope that's fine explanation 👍

Zcooger avatar Nov 29 '20 09:11 Zcooger