pg_auto_failover icon indicating copy to clipboard operation
pg_auto_failover copied to clipboard

Published 20 hours ago • verified publisher icon hapostgres

PostgreSQL 16 support

Open devrimgunduz opened this issue 9 months ago • 14 comments

Hi @dimitri @DimCitus ,

2.0 fails to build against v16. v16 is due next week. Can you please take a look?

Thanks!

Regards, Devrim

devrimgunduz avatar Sep 07 '23 14:09 devrimgunduz

ping

devrimgunduz avatar Sep 13 '23 22:09 devrimgunduz

It's out... https://www.postgresql.org/about/news/postgresql-16-released-2715/

kevinelliott avatar Sep 15 '23 03:09 kevinelliott

Anyone add support?

kevinelliott avatar Sep 19 '23 00:09 kevinelliott

Well I kind of expected a contributor to maybe open a PR with the small amount of fixes required, but apparently even in the Free Software and Open Source communities the default of seeing oneself simply as a consumer prevails. Or maybe I'm just having a bad day. It's not all complaining though, I also got the ball rolling.

dimitri avatar Sep 20 '23 17:09 dimitri

@dimitri I certainly would contribute (as I do to many other repositories), though on reviewing your initial PR it is clear to me that I would have missed a lot of touch points. I'll try to make some effort to support in the future.

kevinelliott avatar Sep 21 '23 17:09 kevinelliott

Hi @dimitri ,

Can you please release a new version?

Thanks!

Cheers, Devrim

devrimgunduz avatar Sep 25 '23 18:09 devrimgunduz

Hi @devrimgunduz ; I missed that merging #1006 would close this one. Re-opening. We're unfortunately not ready yet. What I did is fix the build, but the tests are still failing when using Postgres 16. More work is needed :/

dimitri avatar Sep 25 '23 18:09 dimitri

Ack, thanks!

devrimgunduz avatar Oct 07 '23 14:10 devrimgunduz

Hi @dimitri,

Any updates?

Cheers, Devrim

devrimgunduz avatar Oct 22 '23 23:10 devrimgunduz

Hi @dimitri

maybe #1013 can be of use to address the minor issues of failing tests for postgres 16.

gkokolatos avatar Nov 16 '23 14:11 gkokolatos

I merged #1013 now, I suppose we should add a new PR that enables the CI testing with Postgres 16, as I don't think the main branch covers it at the moment? (See https://github.com/hapostgres/pg_auto_failover/actions/runs/6906594761)

dimitri avatar Nov 21 '23 11:11 dimitri

Is there going to be a release with 16 support?

Eulerizeit avatar Nov 21 '23 13:11 Eulerizeit

Hi @dimitri,

Please see #1015 which should address the CI testing.

gkokolatos avatar Nov 22 '23 09:11 gkokolatos