lab icon indicating copy to clipboard operation
lab copied to clipboard

removing error truncation from types module

Open saboya opened this issue 3 years ago • 7 comments

This helps when debugging error messages if they´re too long.

saboya avatar Apr 21 '21 16:04 saboya

I see. I searched for anything resembling a discussion about that in the typescript repo and found nothing, which is pretty weird. Not sure what ot think about it too.

saboya avatar Apr 23 '21 11:04 saboya

I'll ask in our TypeScript slack channel just in case someone knows better.

Nargonath avatar Apr 23 '21 13:04 Nargonath

FWIW I couldn't not find any explanation for the deprecation in the TS repo either. I wonder if it's not a documentation error. 🤔

Nargonath avatar Apr 23 '21 13:04 Nargonath

Hmm, the deprecation was introduced in the docs with https://github.com/microsoft/TypeScript-Website/commit/d65e30fe5473656bc34da45f4454259ee29224e7. It can now be found here, listed under Things we should document, but really want to help move people away from.

I think that is about all the reasoning you are going to get.

kanongil avatar Apr 23 '21 15:04 kanongil

Not sure how they are going to move people away from an option that has no alternative =P

saboya avatar Apr 23 '21 15:04 saboya

Thanks @kanongil, I failed to find the information. 🙂

I believe that's something you'd need only in specific cases perhaps that's the reasoning behind it. I don't mind if we choose to add it to be honest. Let's see what other think about it. It will just make it more verbose for every TS users. Perhaps that's something we could add behind a command-line flag (not entirely sure though, I didn't dig through it).

Nargonath avatar Apr 23 '21 15:04 Nargonath

Hiding it behind a command-line flag sounds reasonable, I can do that if we decide to move foward with it.

saboya avatar Apr 23 '21 16:04 saboya