joi-date icon indicating copy to clipboard operation
joi-date copied to clipboard

Add date-fns instead of moment

Open svkorepanov opened this issue 5 years ago • 4 comments

Support plan

  • is this issue currently blocking your project? (no):
  • is this issue affecting a production system? (no):

Context

  • node version: 12.16.1
  • module version: 2.0.1
  • environment (e.g. node, browser, native): browser
  • used with (e.g. hapi application, another framework, standalone, ...): react-hook-form, @hookform/resolvers/joi
  • any other relevant information:

What problem are you trying to solve?

Recently I've faced with date validation via Joi, and luckily I found this library. But unfortunately there is a moment.js in deps and I don't want to bring this library in my project as a dependency. I guess a lot of developers don't want it either. I suggest moving to more modern date library such as date-fns instead of moment.js. And I would happy to help you with this.

Do you have a new or modified API suggestion to solve the problem?

svkorepanov avatar Nov 06 '20 09:11 svkorepanov

Also, would be good to mention that moment js is deprecated. https://momentjs.com/docs/

But my main questions would be: does date-fns use the same date format or API as moment.js? If it isn't, this change can break existing code bases if the update the joi-date version.

vicmars5 avatar Dec 17 '20 18:12 vicmars5

Hi 👋 Any update on this topic ?

Izabrr avatar Mar 09 '21 16:03 Izabrr

I don't have time to do the work but if someone wants to open a PR for this, I'll review.

hueniverse avatar Mar 09 '21 20:03 hueniverse

@hueniverse I opened this one

Izabrr avatar Mar 10 '21 09:03 Izabrr