hapi.dev icon indicating copy to clipboard operation
hapi.dev copied to clipboard

Add proper translations for default auth behavior

Open Nargonath opened this issue 4 years ago • 2 comments
trafficstars

Context

  • node version: n/a
  • module version: latest

What are you trying to achieve or the steps to reproduce ?

An issue was raised #459 which was fixed in this MR #460 regarding a mismatch between the documentation and the actual default auth strategy behavior. It was fixed in english but not in the other languages. This is a follow-up of #461.

This was fixed in english and we need to update the tutorial in other languages. Here are the missing translations:

  • [x] pt-BR
  • [ ] ko-KR
  • [ ] tr-TR
  • [ ] zh-ZN

Any help is appreciated here since the core team cannot work on these translations. If you want to participate just open a PR and mention this issue without Fixes or Closes keywords and we'll tick the related tasks ourselves.

Thank you.

Nargonath avatar Apr 16 '21 13:04 Nargonath

I can maybe help with pt-BR. Is this what needs to be translated?

Note that all routes will have the default applied to them, even the ones added before server.auth.default() is called.

afgallo avatar Apr 19 '21 10:04 afgallo

Yes exactly @afgallo, thank you.

Nargonath avatar Apr 19 '21 12:04 Nargonath