hapi.dev icon indicating copy to clipboard operation
hapi.dev copied to clipboard

Fix carbon ads and nuxt target 'static'

Open Nargonath opened this issue 5 years ago • 2 comments
trafficstars

Support plan

  • is this issue currently blocking your project? (yes/no):
  • is this issue affecting a production system? (yes/no):

Context

  • node version:
  • module version with issue:
  • last module version without issue:
  • environment (e.g. node, browser, native):
  • used with (e.g. hapi application, another framework, standalone, ...):
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

const some = 'properly formatted code example';

What was the result you got?

When building the website using target: 'static' in nuxt.config.js the carbon ads script tag is not added to the DOM hence ads are not showing up.

What result did you expect?

Ads should be displayed. We've removed the target: 'static' for now (#438)

Perhaps the problem comes from the mounted lifecycle which is not triggered when generating the website statically.

Nargonath avatar Nov 20 '20 16:11 Nargonath

@Nargonath is this still valid?

geek avatar Jul 30 '23 20:07 geek

@geek I haven't retested but unless somebody fixed it I would assumed it's still the same. Perhaps we don't care about the target: 'static' configuration though. I don't remember exactly the difference between the two.

Nargonath avatar Sep 04 '23 11:09 Nargonath