hapi-pino icon indicating copy to clipboard operation
hapi-pino copied to clipboard

Published 20 hours ago • verified publisher icon hapijs

Make wrapSerializers optional

Open lukeg90 opened this issue 3 years ago • 2 comments

I think this should have been added as an optional property.

lukeg90 avatar Jun 14 '22 17:06 lukeg90

Could you add a test for this? We use tsd to test our types

Add a test for what exactly? The property is already included in this test file:

https://github.com/pinojs/hapi-pino/blob/master/index.test-d.ts

lukeg90 avatar Jun 16 '22 13:06 lukeg90

If a change is needed, then the existing tests are not covering it. Therefore we need a new test.

mcollina avatar Jun 18 '22 10:06 mcollina

These changes were implemented by #173. Should we close this PR?

jonathansamines avatar Oct 22 '22 23:10 jonathansamines