org.hl7.fhir.core icon indicating copy to clipboard operation
org.hl7.fhir.core copied to clipboard

Specific message return when unknown profile cannot be fetched.

Open dotasek opened this issue 2 years ago • 1 comments

When the ValidatorFetcher reports that it won't attempt to fetch a resource, return false, PLUS a reason.

DO NOT MERGE YET, please.

This requires the following before it is ready to merge:

  • [ ] I18n changes to match Messages.properties

dotasek avatar May 04 '22 20:05 dotasek

Codecov Report

Merging #805 (005bc61) into master (3712804) will increase coverage by 0.01%. The diff coverage is 65.00%.

@@             Coverage Diff              @@
##             master     #805      +/-   ##
============================================
+ Coverage      9.80%    9.81%   +0.01%     
- Complexity    12888    28745   +15857     
============================================
  Files          2205     2205              
  Lines        912007   912016       +9     
  Branches     273367   273367              
============================================
+ Hits          89382    89479      +97     
+ Misses       788765   788678      -87     
+ Partials      33860    33859       -1     
Impacted Files Coverage Δ
...ava/org/hl7/fhir/utilities/i18n/I18nConstants.java 0.00% <ø> (ø)
...l7/fhir/validation/instance/InstanceValidator.java 58.07% <36.36%> (+<0.01%) :arrow_up:
...v30_40/resources30_40/AllergyIntolerance30_40.java 3.25% <100.00%> (ø)
...java/org/hl7/fhir/validation/ValidationEngine.java 34.57% <100.00%> (+1.38%) :arrow_up:
...ation/cli/services/StandAloneValidatorFetcher.java 34.96% <100.00%> (-2.63%) :arrow_down:
...in/java/org/hl7/fhir/exceptions/FHIRException.java 50.00% <0.00%> (-25.00%) :arrow_down:
.../fhir/convertors/txClient/TerminologyClientR4.java 0.00% <0.00%> (-12.97%) :arrow_down:
.../convertors/txClient/TerminologyClientFactory.java 20.00% <0.00%> (-11.43%) :arrow_down:
...java/org/hl7/fhir/r4b/model/ElementDefinition.java 13.28% <0.00%> (+0.03%) :arrow_up:
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6df50d4...005bc61. Read the comment docs.

codecov[bot] avatar May 04 '22 20:05 codecov[bot]