hapifhir
Update semver regex
https://chat.fhir.org/#narrow/stream/179252-IG-creation/topic/Semver.20validation
I don’t think this is enough by a long shot. If we’re going to allow + in semver versions, it needs a lot of testing so that we know it works across the whole ecosystem. Does the validator support this? Do the package servers support it? Does the publisher support it?
And in the code, does versionutilities support it?
I see - yes, that of course makes sense.
But this change may be a good starting point. And, the current version (in production) of the regex already allowed the following: 1.0.0-asdf+asdf+asfd
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 12.07%. Comparing base (
f9a3501) to head (4511275). Report is 14 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #1594 +/- ##
============================================
+ Coverage 12.05% 12.07% +0.02%
- Complexity 31149 31241 +92
============================================
Files 2167 2175 +8
Lines 670269 670467 +198
Branches 197931 197960 +29
============================================
+ Hits 80773 80945 +172
- Misses 560400 560407 +7
- Partials 29096 29115 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
see https://chat.fhir.org/#narrow/stream/179239-tooling/topic/NPM.20.26.20SemVer
see https://chat.fhir.org/#narrow/stream/179239-tooling/topic/NPM.20.26.20SemVer: it's good to go, and we need to do this across the board
to test:
- support for + in FilesystemBasedPackageCache
- support for + on packages.fhir.org
- support in the package client
- validation in FHIRVersion elements
- support in go-publish