hapi-fhir icon indicating copy to clipboard operation
hapi-fhir copied to clipboard

Published 20 hours ago • verified publisher icon hapifhir

Bump org.hl7.fhir.core library to latest release version (6.2.6)

Open dotasek opened this issue 1 year ago • 3 comments

This issue is to track the process of updating the org.hl7.fhir.core library to the latest release version (6.2.6 at this time)

Since this process involves adapting to many changes in the core library in our wrappers, it may have some nuances beyond updating method signatures.

dotasek avatar Dec 15 '23 19:12 dotasek

I believe in preparation for the management of multi-FHIR-version IGs, there are a host of new methods that add a FhirPublication parameter to an existing method signature.

I implemented these just enough to get tests passing, but I do have a concern that these will result in difficult to diagnose errors further down the road.

https://github.com/hapifhir/hapi-fhir/blob/fc0faa767610e91e1e77d72fe8ea733250bcd1f1/hapi-fhir-structures-r5/src/main/java/org/hl7/fhir/r5/hapi/ctx/HapiWorkerContext.java#L164

https://github.com/hapifhir/hapi-fhir/blob/fc0faa767610e91e1e77d72fe8ea733250bcd1f1/hapi-fhir-validation/src/main/java/org/hl7/fhir/common/hapi/validation/validator/VersionSpecificWorkerContextWrapper.java#L626

dotasek avatar Dec 15 '23 19:12 dotasek

Fix here seems weirdly arbitrary:

https://github.com/hapifhir/hapi-fhir/commit/73eb12778ccf806d01d4334618217300b7288c98#r135113418

dotasek avatar Dec 15 '23 19:12 dotasek

These added narratives are placeholders; they need to be replaced with something that conforms to FHIR best practices for narratives:

https://github.com/hapifhir/hapi-fhir/blob/ca84cb74df4d06963c322baee555441b36f98eaa/hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/provider/ServerCapabilityStatementProvider.java#L211

https://github.com/hapifhir/hapi-fhir/blob/ca84cb74df4d06963c322baee555441b36f98eaa/hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/provider/ServerCapabilityStatementProvider.java#L712

https://github.com/hapifhir/hapi-fhir/blob/ca84cb74df4d06963c322baee555441b36f98eaa/hapi-fhir-server/src/main/java/ca/uhn/fhir/rest/server/provider/ServerCapabilityStatementProvider.java#L211

dotasek avatar Dec 18 '23 23:12 dotasek

Superseded by https://github.com/hapifhir/hapi-fhir/pull/5772 - HAPI, at the time of this comment, uses version 6.3.11 of core.

dotasek avatar Jul 17 '24 17:07 dotasek