hapi-fhir
hapi-fhir copied to clipboard
remove requirement to have 'missing' idxs enabled for patient bulk export
TBH, I'm not clear why missing indexes were required for patient bulk export in the first place. So I'm not certain if this PR is "safe". But submitting for review in the hopes it was some old holdover that is no longer necessary.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
2f5ffe7
) 81.32% compared to head (639bf75
) 82.99%. Report is 340 commits behind head on master.
:exclamation: Current head 639bf75 differs from pull request most recent head 9b15329. Consider uploading reports for the commit 9b15329 to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #5447 +/- ##
============================================
+ Coverage 81.32% 82.99% +1.66%
- Complexity 23650 26491 +2841
============================================
Files 1425 1630 +205
Lines 86399 102758 +16359
Branches 11677 13115 +1438
============================================
+ Hits 70265 85279 +15014
- Misses 10947 11872 +925
- Partials 5187 5607 +420
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
From what I've gathered in a very short and not accurate search, the class JpaBulkExportProcessor was introduced in #3566, and the requirement for IndexMissingFields=ENABLED could possibly be dropped after this PR was merged: #3982
Before that change, maybe not all resources linked to the patient could be exported correctly, or errors were thrown anyway (just guessing).
I obviously don't have the full picture yet. Just stumbled on this issue and wanted to know more about it.