hapi-fhir icon indicating copy to clipboard operation
hapi-fhir copied to clipboard

Add Support for Custom MDM Matcher algorithms

Open nigtrifork opened this issue 2 years ago • 5 comments

Currently all available FHIR Element Matchers are defined in ca.uhn.fhir.mdm.rules.matcher.MdmMatcherEnum.

This does not allow for defining custom matchers, since it the enum can not be extended.

It would be very handy to be able to implement and somehow register a custom implementation of the ca.uhn.fhir.mdm.rules.matcher.IMdmFieldMatcher interface, and the use that matcher when defining MDM rules.

The same goes for ca.uhn.fhir.mdm.rules.similarity.MdmSimilarityEnum and ca.uhn.fhir.mdm.rules.similarity.IMdmFieldSimilarity

nigtrifork avatar Jun 19 '23 11:06 nigtrifork

@jamesagnew would you guys be open for this?

jkiddo avatar Jun 25 '23 14:06 jkiddo

Any updates on this? I need to write many different algorithms that would improve MDM's matching.

michealharrington avatar Apr 03 '24 17:04 michealharrington

Ping @dotasek

jkiddo avatar Apr 03 '24 17:04 jkiddo

Heya all, this is a heavy lift internally, so its unlikely to occur in the short term. That said, if you want to contribute an enum value, matcher and the related code, I would be glad to review it and get it merged in.

tadgh avatar Apr 04 '24 16:04 tadgh

Echoing what Gary is saying. If there are matchers we haven't yet created that you need, why not submit them as a PR along with additional enum values for them so that the community can benefit?

jamesagnew avatar Apr 04 '24 19:04 jamesagnew