rollup of review comments

[tadgh]

This is a rollup of review comments that should be addressed in the future from PR: https://github.com/hapifhir/hapi-fhir/pull/3842

I wonder if a separate class can be used to de-duplicate some of these?

I know it's tricky with the different models, so feel free to let me know if that's even possible.

Originally posted by @TipzCM in https://github.com/hapifhir/hapi-fhir/pull/3842#discussion_r935887726

---

Q: What's a type-source resource?

Is this like "Patient" "Observation" etc?

If so, should we be verifying that they are indeed also valid resource types?

Originally posted by @TipzCM in https://github.com/hapifhir/hapi-fhir/pull/3842#discussion_r935865898

---

Since these are new methods, i strongly suggest using a parameter object to take all these values instead of massive signatures that can easily be confused...

For instance, this method has 4 parameters that are all of the exact same type. Which is likely to lead to errors.

Originally posted by @TipzCM in https://github.com/hapifhir/hapi-fhir/pull/3842#discussion_r935871282

---

These 2 tests look very similar. Is there a way we can combine them?

Use a parameterized test or a method that is called that does the 'similar' work?

Originally posted by @TipzCM in https://github.com/hapifhir/hapi-fhir/pull/3842#discussion_r935879653

---

See Above

Originally posted by @TipzCM in https://github.com/hapifhir/hapi-fhir/pull/3842#discussion_r935879755