hapi-fhir icon indicating copy to clipboard operation
hapi-fhir copied to clipboard

Fix NPE in MDM post-mdm-clear on UPDATE operations.

Open tadgh opened this issue 3 years ago • 1 comments

  • Add changelog.
  • Handle update with no previous golden record.
  • Add test.

Closes #3786

tadgh avatar Jul 27 '22 03:07 tadgh

Codecov Report

Patch coverage: 69.99% and project coverage change: -1.24% :warning:

Comparison is base (c29bb46) 83.00% compared to head (ef5d1bd) 81.77%. Report is 657 commits behind head on master.

:exclamation: Current head ef5d1bd differs from pull request most recent head 2f05b0b. Consider uploading reports for the commit 2f05b0b to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3851      +/-   ##
============================================
- Coverage     83.00%   81.77%   -1.24%     
+ Complexity    21378    20674     -704     
============================================
  Files          1424     1413      -11     
  Lines         77032    76958      -74     
  Branches      11384    11055     -329     
============================================
- Hits          63942    62929    -1013     
- Misses         8705     9877    +1172     
+ Partials       4385     4152     -233     
Files Changed Coverage Δ
...-fhir-base/src/main/java/ca/uhn/fhir/i18n/Msg.java 100.00% <ø> (ø)
...uhn/fhir/interceptor/model/RequestPartitionId.java 92.15% <ø> (ø)
...rc/main/java/ca/uhn/fhir/model/primitive/IdDt.java 74.58% <ø> (ø)
.../src/main/java/ca/uhn/fhir/rest/api/Constants.java 100.00% <ø> (ø)
...base/src/main/java/ca/uhn/fhir/util/ArrayUtil.java 100.00% <ø> (ø)
...ava/ca/uhn/fhir/rest/client/method/MethodUtil.java 77.85% <0.00%> (-4.41%) :arrow_down:
...in/java/ca/uhn/fhir/jpa/batch/BatchJobsConfig.java 100.00% <ø> (ø)
...va/ca/uhn/fhir/jpa/batch/CommonBatchJobConfig.java 50.00% <ø> (-50.00%) :arrow_down:
...h/processor/GoldenResourceAnnotatingProcessor.java 2.32% <0.00%> (-79.26%) :arrow_down:
...n/java/ca/uhn/fhir/jpa/batch2/JpaBatch2Config.java 83.33% <ø> (-16.67%) :arrow_down:
... and 72 more

... and 247 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 27 '22 06:07 codecov[bot]

@tadgh this was never merged? Why?

jkiddo avatar Sep 07 '23 15:09 jkiddo

Hmm probably it had no internal tracking. I'll get it merged today

On Thu, Sep 7, 2023, 8:12 AM Jens Kristian Villadsen < @.***> wrote:

@tadgh https://github.com/tadgh this was never merged? Why?

— Reply to this email directly, view it on GitHub https://github.com/hapifhir/hapi-fhir/pull/3851#issuecomment-1710328558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANEA4JOFZGTM3YEIHQ25FDXZHP4VANCNFSM54YB77BA . You are receiving this because you were mentioned.Message ID: @.***>

tadgh avatar Sep 07 '23 15:09 tadgh

Formatting check succeeded!

github-actions[bot] avatar Sep 07 '23 21:09 github-actions[bot]