hapi-fhir icon indicating copy to clipboard operation
hapi-fhir copied to clipboard

$reindex does not work in version 6.0.0, search with _include does not work with target type

Open phu-medring opened this issue 2 years ago • 11 comments

Describe the bug I upgrade version 6.0.0 hapi-fhir-jpaserver-starter

  • /$reindex is not work (I see that reindexProvider is removed from BaseJpaRestfulServer.java)
  • Can't include with 3 paths ( if parameter has target resource , server returns error)

To Reproduce Steps to reproduce the behavior:

  1. Call: POST /$reindex Content-Type: application/fhir+json { "resourceType": "Parameters", "parameter": [ { "name": "everything", "valueBoolean": "true" }, { "name": "batchSize", "valueDecimal": 1000 } ] } --> return : "issue": [ { "severity": "error", "code": "not-supported", "diagnostics": "Invalid request: The FHIR endpoint on this server does not know how to handle POST operation[$reindex] with parameters [[]]" } ]

  2. Call API: http://hapi.fhir.org/baseR4/Appointment?_include=Appointment:supporting-info:Condition return: "issue": [ { "severity": "error", "code": "processing", "diagnostics": "Named parameter not bound : target_resource_types" } ]

Expected behavior

  1. Can call $reindex op
  2. Include search: work with 3 paths

Environment (please complete the following information):

  • HAPI FHIR Version: 6.0.0

phu-medring avatar May 23 '22 04:05 phu-medring

Heya, thanks for reporting this, I will have a look in the morning to replicate the issue.

On Sun, May 22, 2022, 9:49 PM Phudd @.***> wrote:

Describe the bug I upgrade version 6.0.0 hapi-fhir-jpaserver-starter https://github.com/hapifhir/hapi-fhir-jpaserver-starter

  • /$reindex is not work (I see that reindexProvider is removed from BaseJpaRestfulServer.java)
  • Can't include with 3 paths ( if parameter has target resource , server returns error)

To Reproduce Steps to reproduce the behavior:

Call: POST /$reindex Content-Type: application/fhir+json { "resourceType": "Parameters", "parameter": [ { "name": "everything", "valueBoolean": "true" }, { "name": "batchSize", "valueDecimal": 1000 } ] } --> return : "issue": [ { "severity": "error", "code": "not-supported", "diagnostics": "Invalid request: The FHIR endpoint on this server does not know how to handle POST operation[$reindex] with parameters [[]]" } ] 2.

Call API: http://hapi.fhir.org/baseR4/Appointment?_include=Appointment:supporting-info:Condition return: "issue": [ { "severity": "error", "code": "processing", "diagnostics": "Named parameter not bound : target_resource_types" } ] Expected behavior 3.

Can call $reindex op 4.

Include search: work with 3 paths

Environment (please complete the following information):

  • HAPI FHIR Version: 6.0.0

— Reply to this email directly, view it on GitHub https://github.com/hapifhir/hapi-fhir/issues/3633, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANEA4OSPZKHFFQBJEWDIWDVLME35ANCNFSM5WUQ6HNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

tadgh avatar May 23 '22 04:05 tadgh

Heya, can you pull hapi-fhir-jpaserer 6.0.1 and try that? https://github.com/hapifhir/hapi-fhir-jpaserver-starter/tree/rel_6_0_1

tadgh avatar May 23 '22 22:05 tadgh

Hello @tadgh I also tried to use hapi-fhir-jpaserer 6.0.1 but issue is not fixed.

phu-medring avatar May 24 '22 01:05 phu-medring

WHen I use version 6.0.1, $reindex is working well, but http://hapi.fhir.org/baseR4/Appointment?_include=Appointment:supporting-info:Condition still got error.

phu-medring avatar May 31 '22 04:05 phu-medring

Ah, that server is not yet updated. We will get to it ASAP :)

On Tue, May 31, 2022 at 12:20 AM Phudd @.***> wrote:

WHen I use version 6.0.1, $reindex is working well, but http://hapi.fhir.org/baseR4/Appointment?_include=Appointment:supporting-info:Condition still got error.

— Reply to this email directly, view it on GitHub https://github.com/hapifhir/hapi-fhir/issues/3633#issuecomment-1141651758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANEA4L6OLMBTRV7Q6IHBLTVMWHOZANCNFSM5WUQ6HNA . You are receiving this because you were mentioned.Message ID: @.***>

-- --Gary

tadgh avatar May 31 '22 14:05 tadgh

I also experience the _include error with extended paths since 6.0, any followup on this? Thanks.

dennisverspuij avatar Jun 20 '22 08:06 dennisverspuij

Is there any update on this? We are also experiencing the "Named parameter not bound : target_resource_types" problem when specifying a target type in any _include parameter. We are using HAPI version 6.0.1 with a PostgreSQL database. In version 5.7.0 the error did not occur.

jmvdgraaf avatar Jul 29 '22 06:07 jmvdgraaf

Hello again, for me this issue has been a v6 showstopper for a while, but I am unable to track down where and what change exactly causes the issue as of v6. Is there someone who can pick this up or direct me to the change so I can attempt to fix myself. Thnx very much,

dennisverspuij avatar Aug 23 '22 09:08 dennisverspuij

Heya! It was release time, so this one got lost in the weeds. I'm off this week but I'll flag this to my team, and get it escalated.

tadgh avatar Aug 23 '22 15:08 tadgh

Heya, I just found this recently merged ticket which I believe addresses this:

https://github.com/hapifhir/hapi-fhir/pull/3938 and related issue: https://github.com/hapifhir/hapi-fhir/issues/3937

The most recent 6.2.0-PRE snapshot should have this fix.

tadgh avatar Aug 23 '22 15:08 tadgh

Thanks, will have a look!

dennisverspuij avatar Aug 25 '22 07:08 dennisverspuij