hapi-fhir-jpaserver-starter
hapi-fhir-jpaserver-starter copied to clipboard
hapifhir
Circular references from core library in 5.7.0
***************************
APPLICATION FAILED TO START
***************************
Description:
The dependencies of some of the beans in the application context form a cycle:
┌──->──┐
| fhirServerConfigR4 (field private ca.uhn.fhir.jpa.api.dao.DaoRegistry ca.uhn.fhir.jpa.config.BaseConfig.myDaoRegistry)
└──<-──┘
Action:
Relying upon circular references is discouraged and they are prohibited by default. Update your application to remove the dependency cycle between beans. As a last resort, it may be possible to break the cycle automatically by setting spring.main.allow-circular-references to true.
@tadgh or SmileCDR-folks: Could you please have a look while I'll overwrite it for now in the default settings
Where are you seeing this? hapi-fhir-jpaserver-starter? FWIW we are completely ripping out these configs in 6.0.0, but im happy to release a 5.7.1 with this fixed
Can you do me a favour and checkout rel_5_7 and see if that works for you locally? if so, i'll work on merging it into master. It is booting for me.
Wait, overwrite which in the yaml? is it working or no? Happy to dig into this if it is broken, either way i'll have rel_5_7 up shortly.
@tadgh if you remove https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/deefd595dd0189efe9f1945a7aac7757a04f3cba/src/main/resources/application.yaml#L2 and https://github.com/hapifhir/hapi-fhir-jpaserver-starter/blob/master/src/main/resources/application.yaml#L3 you can see the error on the master branch
Right, we've completely reworked the config in 6.0.0, so i think it's probably going to stay broken until then unless the fix is dead easy and we have a reason to backport it. I'll open a branch now to bump to 6.0.0 and we'll see what the error looks like there.
@tadgh I'm fine closing this. There's no reason to add extra work for you guys if this has changed alot in 6.0.0
I wanted to wait until we get the 6_0_0 branch finished to see if the cycle still exists before closing this out, if that works
On Fri, Feb 25, 2022 at 12:13 PM Jens Kristian Villadsen < @.***> wrote:
@tadgh https://github.com/tadgh I'm fine closing this. There's no reason to add extra work for you guys if this has changed alot in 6.0.0
— Reply to this email directly, view it on GitHub https://github.com/hapifhir/hapi-fhir-jpaserver-starter/issues/315#issuecomment-1051193594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANEA4PECTJ7AXOYACNILDLU47PEZANCNFSM5OWHNF4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
-- --Gary
still getting the issue with 6.0.1 if i remove allow-circular-references: true from the application.yaml
