react-flatpickr icon indicating copy to clipboard operation
react-flatpickr copied to clipboard

Bump flatpickr to 4.6.13 (fix issues)

Open nicofrand opened this issue 2 years ago • 3 comments

Hi,

Thanks for react-flatpickr, it's really nice!

Several bugs were fixed in flatpickr version 4.6.13 (in my case in particular the change event being fired twice).

The react-flatpickr yarn.lock file defines version 4.6.9: in the lockfile: https://github.com/haoxins/react-flatpickr/blob/master/yarn.lock#L4035, which means we still have the issue.

We can fix the issue with

"resolutions": {
    "flatpickr": "^4.6.13"
  },

but it would be nice if you could please bump the version to 4.6.13 so that we don't have to use the resolutions hack.

?

nicofrand avatar Jul 20 '22 09:07 nicofrand

yarn.lock is not respected for dependencies, only the current project. A yarn upgrade or npm upgrade in your own project should be enough to upgrade the transitive flatpickr dependency.

Duplicate of #77 and #80

jacobmischka avatar Jul 20 '22 15:07 jacobmischka

Thank you for your answer. Would you know why $ yarn upgrade react-flatpickr --latest isn't enough though?

Before upgrade:

$ grep flatpickr yarn.lock -A 2
"@types/react-flatpickr@^3.8.6":
  version "3.8.6"
  resolved "https://registry.yarnpkg.com/@types/react-flatpickr/-/react-flatpickr-3.8.6.tgz#5ecd5ba47d4f32a20d9045b41e047e6e16cc2e69"
  integrity sha512-EhlqO1P0jnlTyYMHgaXRcuWxBqdVtmepl5j9FxoZS8jBxyx1z6AN8K4/WyYS4ijiMsBNDGyagjRXQbAfgvao4w==
  dependencies:
--
    flatpickr "^4.0.6"

"@types/react-redux@^7.1.24":
--
flatpickr@^4.0.6, flatpickr@^4.6.2:
  version "4.6.9"
  resolved "https://registry.yarnpkg.com/flatpickr/-/flatpickr-4.6.9.tgz#9a13383e8a6814bda5d232eae3fcdccb97dc1499"
  integrity sha512-F0azNNi8foVWKSF+8X+ZJzz8r9sE1G4hl06RyceIaLvyltKvDl6vqk9Lm/6AUUCi5HWaIjiUbk7UpeE/fOXOpw==

--
react-flatpickr@^3.10.11:
  version "3.10.12"
  resolved "https://registry.yarnpkg.com/react-flatpickr/-/react-flatpickr-3.10.12.tgz#c07f39f553865bc7063b69586ffc9d36759e6915"
  integrity sha512-NYhUg3QE9K1QpHXLxR7HuWldnNbVWa6lgiZBlWu0HDsX3IWs/hVJ5q1JzM0/CNLJmm2blUEdudHwbyBNezynBg==
  dependencies:
    flatpickr "^4.6.2"
    prop-types "^15.5.10"

Then I upgrade react-flatpickr:

$ yarn upgrade react-flatpickr --latest

After:

[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
[5/5] Rebuilding all packages...
success Saved lockfile.
success Saved 1 new dependency.
info Direct dependencies
└─ [email protected]
info All dependencies
└─ [email protected]
Done in 8.83s.

$ grep flatpickr yarn.lock -A 2
"@types/react-flatpickr@^3.8.6":
  version "3.8.6"
  resolved "https://registry.yarnpkg.com/@types/react-flatpickr/-/react-flatpickr-3.8.6.tgz#5ecd5ba47d4f32a20d9045b41e047e6e16cc2e69"
  integrity sha512-EhlqO1P0jnlTyYMHgaXRcuWxBqdVtmepl5j9FxoZS8jBxyx1z6AN8K4/WyYS4ijiMsBNDGyagjRXQbAfgvao4w==
  dependencies:
--
    flatpickr "^4.0.6"

"@types/react-redux@^7.1.24":
--
flatpickr@^4.0.6, flatpickr@^4.6.2:
  version "4.6.9"
  resolved "https://registry.yarnpkg.com/flatpickr/-/flatpickr-4.6.9.tgz#9a13383e8a6814bda5d232eae3fcdccb97dc1499"
  integrity sha512-F0azNNi8foVWKSF+8X+ZJzz8r9sE1G4hl06RyceIaLvyltKvDl6vqk9Lm/6AUUCi5HWaIjiUbk7UpeE/fOXOpw==

--
react-flatpickr@^3.10.13:
  version "3.10.13"
  resolved "https://registry.yarnpkg.com/react-flatpickr/-/react-flatpickr-3.10.13.tgz#5b9d8f35f84e43f342fb0f0334b78a8dcd7d67c4"
  integrity sha512-4m+K1K8jhvRFI8J/AHmQfA5hLALzhebEtEK8mLevXjX24MV3u502crzBn+EGFIBOfNUtrL5PId9FsGwgtuz/og==
  dependencies:
    flatpickr "^4.6.2"
    prop-types "^15.5.10"

nicofrand avatar Jul 20 '22 15:07 nicofrand

That's unfortunately a bug in yarn https://github.com/yarnpkg/yarn/issues/4986.

The best solution I know about if you want to update it selectively is to delete the flatpickr@^4.0.6, flatpickr@^4.6.2 entry from yarn.lock manually and run yarn, it will regenerate it with the updated version.

Sorry about that!

jacobmischka avatar Jul 20 '22 18:07 jacobmischka