shaoyue

Results 84 comments of shaoyue

It's a bug due to careless golang interface conversion in parsing request. It's not an overflow but a precision lost when converting from float64 to int64. https://github.com/milvus-io/milvus/blob/master/internal/distributed/proxy/httpserver/wrap_request.go#L133 here is a...

Same problem may also apply to other sdks, whose language uses float64 for number types. eg: node sdk with typescript. Can you help to test & prove it?

> Same problem may also apply to other sdks, whose language uses float64 for number types. eg: node sdk with typescript. Can you help to test & prove it? #16951

> So json unmarshal treat all data types as float? all `number` data, yes, as well as many other major json libs

FYI It's stated in the RFC standard of JSON: https://datatracker.ietf.org/doc/html/rfc8259 ``` This specification allows implementations to set limits on the range and precision of numbers accepted. Since software that implements...

@larry88 thanks again for this feedback. It really saved us from many troubles to come.

> /assign @haorenfsa would you like to fix it? Fix in #20468, need review

/reopen solved for: - [x] bulkinsert - [x] restapi not solved for: - [ ] node sdk - [ ] attu

> /reopen > > solved for: > > * [x] bulkinsert > * [x] restapi > > not solved for: > > * [ ] node sdk > * [...