voicefixer_main icon indicating copy to clipboard operation
voicefixer_main copied to clipboard

super_resolution should be True?

Open m-mandel opened this issue 2 years ago • 1 comments

https://github.com/haoheliu/voicefixer_main/blob/b15d20d2456c4158a55d7b66aed67b9b994f9143/config/vctk_base_ssr_unet_super_resolution.json#L20

Should the configuration for super resolution be as follows?

 "ssr":{
      "ssr_task": {
        "dereverberation": false,
        "denoising": false,
        "declipping": false,
        "super_resolution": true
      },

instead of:

 "ssr":{
      "ssr_task": {
        "dereverberation": false,
        "denoising": true,
        "declipping": false,
        "super_resolution": false
      },

m-mandel avatar Jul 13 '22 12:07 m-mandel

Hi @mosem Thanks for pointing out. This part of configuration is a little bit redundancy, which means it's not actually used by code. So changing this part will not affect the program behavior. Many apologizes for the confusion. I'll try to fix this issue and resolve the confusion lately.

Haohe

haoheliu avatar Aug 03 '22 10:08 haoheliu