FastVideo icon indicating copy to clipboard operation
FastVideo copied to clipboard

Duplicated code in the training pipeline.

Open EricLina opened this issue 2 months ago • 2 comments

I think the following codes should be removed, right?

        validation_batch.total_loss = validation_batch.total_loss
        validation_batch.grad_norm = validation_batch.grad_norm

https://github.com/hao-ai-lab/FastVideo/blob/9ce7c8039e3fec4c632b8d29a2e41e418a9b56d6/fastvideo/training/training_pipeline.py#L522

EricLina avatar Oct 09 '25 04:10 EricLina

Training part is used here? Validation part could be removed.

BrianChen1129 avatar Oct 09 '25 04:10 BrianChen1129

But the following part in the training code still seems duplicated:

        training_batch.total_loss = training_batch.total_loss
        training_batch.grad_norm = training_batch.grad_norm

ref to here.

EricLina avatar Oct 09 '25 04:10 EricLina