go-fuse icon indicating copy to clipboard operation
go-fuse copied to clipboard

Make pollHack work on read-only mounts on Darwin

Open valeriangalliat opened this issue 2 years ago • 2 comments

Ports commit fee50bf01cd60f66c82493761756b2c345a86aa3 to poll_darwin.go in order to allow read-only mounts on Darwin as well.

Fixes https://github.com/rfjakob/gocryptfs/issues/595 where we can't use gocryptfs -ro or gocryptfs -reverse on macOS because go-fuse tries to write to the read-only mountpoint during initial mount.

Cheers!

Edit: signed the CLA and re-pushed so automated checks pass

Edit: potentially fixes #373

valeriangalliat avatar Mar 07 '22 02:03 valeriangalliat

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

google-cla[bot] avatar Mar 07 '22 02:03 google-cla[bot]

could you send me a review through gerrithub? See https://github.com/hanwen/go-fuse/blob/master/CONTRIBUTING

hanwen avatar May 19 '22 14:05 hanwen

as this is open for a while now and a dealbreaker on OSX - maybe a little bump

krim404 avatar Aug 21 '22 22:08 krim404

merged in https://github.com/hanwen/go-fuse/commit/58a7e145ff0d052afbbf8bb53120572b99c7faaf - can be closed

krim404 avatar Aug 22 '22 12:08 krim404

Awesome, thanks for the bump and getting this patch though! ❤️

valeriangalliat avatar Aug 22 '22 12:08 valeriangalliat