add Options{RootStableAttr} field

[stevegt]

This pull request implements option (5) in #399.

• provides an optional way to set e.g. Ino and/or Gen for the root directory when calling fs.Mount()
• provides example/root-ino but no new test cases
• partial fix for #399

[rfjakob]

Can you push this to https://gerrithub.io/ acc. to https://github.com/hanwen/go-fuse/blob/master/CONTRIBUTING ?

[stevegt]

I've been avoiding gerrithub because it is not clear from https://github.com/hanwen/go-fuse/blob/master/CONTRIBUTING and https://review.gerrithub.io/static/intro.html what permissions I need to grant to gerrithub in order to contribute, and I'd prefer to not give a third party the ability to write to my github repos. I've set it up read-only and pushed. If read-only works, then we'll probably want to mention it in CONTRIBUTING.

[hanwen]

you can pick 'reviewer' option which shouldn't require handing out push access.

[stevegt]

you can pick 'reviewer' option which shouldn't require handing out push access.

I think that's what I did on 06 Nov -- it's sitting there waiting for your review/approval, I think. Let me know if for some reason that didn't work. https://review.gerrithub.io/c/hanwen/go-fuse/+/526907

[rfjakob]

@stevegt some comments accumulated on gerrithub. Do you want to work on this? The unittest could look like TestMknodNotSupported: https://github.com/hanwen/go-fuse/blob/934a183ed91446d218b5471c4df9f93db039f6e1/fs/simple_test.go#L360

[rfjakob]

(I may pick it up if not)

[stevegt]

@rfjakob Thanks, hadn't seen the comment thread. I'd say whichever one of us gets to it first should go for it. My earliest chance may not be until this weekend.

[adlternative]

Hello, what's this PR situation now? I meet the seem question: I want to set root's stableAttr inode when it mount.

[hanwen]

I asked for a change in the review, and nothing happened. See https://review.gerrithub.io/c/hanwen/go-fuse/+/526907

[stevegt]

@hanwen To be honest, dealing with gerrithub and the multiple sites for conversation and code review is the speed bump that stalled this PR. For a very brief time in late 2021, you had a paid team of several folks focused on building an open-source project on top of go-fuse while contributing back. But due to the 2-month delay related to gerrithub (visible above), our own project went a different direction. Then my close friend and co-worker who was helping me lead that team became too incapacitated from post-COVID complications and has since passed away. The team itself has dissolved and has gone on with their lives.

I have to note that saying "nothing happened" comes across as harsh. My last comment in gerrithub was Agreed -- will tackle a unittest and/or modify loopback if Jakob doesn't get to it first. I provided example/root-ino/main.go mostly to make sure this was the right general direction. You answered sgtm. The change you had asked for was to turn the example code I provided into a unit test. I don't like leaving things unfinished, but with everything that has transpired, I'd suggest that if this is a change you, @rfjakob, or @adlternative would like to see, then I'd encourange one of you to pick it up.

[stevegt]

...and I realize on re-reading that some of what I've said may also come across as harsh, which was not what I intended. Please, if anyone needs this fix, take it from me and run with it. I may need it again myself someday, but at this point can't predict when that might be; my family and I have been necessarily focused on other things. Take care everyone.

[hanwen]

I'm sorry to hear that Covid affected you and your friends so badly.

I don't currently need this proposed feature (I'm not paid to work on go-fuse), but if someone else wants to continue, feel free to pick it up.

[adlternative]

@hanwen To be honest, dealing with gerrithub and the multiple sites for conversation and code review is the speed bump that stalled this PR. For a very brief time in late 2021, you had a paid team of several folks focused on building an open-source project on top of go-fuse while contributing back. But due to the 2-month delay related to gerrithub (visible above), our own project went a different direction. Then my close friend and co-worker who was helping me lead that team became too incapacitated from post-COVID complications and has since passed away. The team itself has dissolved and has gone on with their lives.

I have to note that saying "nothing happened" comes across as harsh. My last comment in gerrithub was Agreed -- will tackle a unittest and/or modify loopback if Jakob doesn't get to it first. I provided example/root-ino/main.go mostly to make sure this was the right general direction. You answered sgtm. The change you had asked for was to turn the example code I provided into a unit test. I don't like leaving things unfinished, but with everything that has transpired, I'd suggest that if this is a change you, @rfjakob, or @adlternative would like to see, then I'd encourange one of you to pick it up.

I'm sorry to hear about the passing of your friend.

I may not be very familiar with the internals of go-fuse, but I will try to complete this patch.

[adlternative]

@stevegt @hanwen I create a new PR: #450, which write the unit test cases for this patch. Should I push it to Gerrit too? :)

[hanwen]

yes , a gerrit change is preferred. Sorry for the inconvenience.

[hanwen]

merged as 615a0a7e1178bdca80868b4f2386a7f762f41e02