Hans Larsen

Results 92 comments of Hans Larsen

Monday I can make the necessary PR to allow a feature flag to disable NaN-boxing. I don't know how long we'll support that flag (some optimizations will rely on JsValue...

BTW it seems that's something that might be able to disable in the kernel. You could try that for the moment.

We might be able to implement `require` at some point but it hasn't been a priority. You can use a bundler like webpack/rollup/esbuild (or other) to remove the require calls.

I can look at it sometimes next week and give you some instructions. I have used many packages from NPM in boa with success, including native node apis (caveat: with...

@jedel1043 I don't know how to manually re-run the test262 on this project, so I'll leave that to you as a reviewer. Thanks!

~~Sounds good. Let me test the test262 on my embedded platform before merging. Will have to wait to Monday.~~ Scratch that. I won't be able to easily run test262, but...

At least 3 tests are failing in `boa_engine`, will investigate Monday. To be fair, they're likely wrong test expectations based on overflow/underflow, but I still want to make sure.

Okay so after running test262 a bunch, and testing in browsers and Deno, I would still like to build this PR the right way but will need to move to...

> This alters the JsValue::as_object API to return a Option instead of Option, which cascades out into some breaking changes in our JsValue APIs and some arguably less ergonomic usage...

> Ideally this should inherit from EventTarget @HalidOdat I was starting work on class inheritance with that specifically in mind, but hit a road block and inheritance in Rust currently...