Hans Knöchel

Results 177 comments of Hans Knöchel

@garymathews As an idea: Using native V8/JSCore constructors, the whole "create" factory could be replaced easily and without wrappers. Same goes for callbacks (e.g. `KrollCallback` on iOS), which could return...

@garymathews iOS 13 is our friend, `Promise` objects in every `JSValue` :) > If you enjoyed our article about JavaScriptCore, you’d be thrilled to know that JSValue objects now natively...

@drauggres Never used it because of performance reasons :) Also, they use a high level implementation with `RCTPromiseResolveBlock` and `RCTPromiseRejectBlock` which looks quite overhead compared to a JSCore implementation.

Well, a low level JSCore / V8 implementation would be more performant to save bridge calls. But either way, a simple object is a good idea!

Yeah, sub-directories can likely cause issues in the current implementation. Will fix in 1.2.0 Beta 2, but tbh, since it is no image, it has nothing to do in images/.

Lottie-files are no images, they are json-based data structures. Put the JSON into app/assets and your normal images in app/assets/images if you want, but that just depends on what your...

The `assetFolder` is Android-only at this time, so I'll move this to be a feature-request instead. Thx!

This is an open source repository, guys. You can either contribute to it or hire someone to do it for you if necessary. Please don't spam GitHub threads like this.

@m1ga Will add it, maybe later this weekend. Shouldn't be a big change, so everyone please feel free to go ahead!

Sorry for the typo, yeah! I can take a look at this over the next weeks.