Hans Kuijpers

Results 25 comments of Hans Kuijpers

closing this PR due to no activity

@mao3li please have a look at the documentation of Magento https://experienceleague.adobe.com/docs/commerce-operations/upgrade-guide/implementation/perform-upgrade.html?lang=en

@markshust is this addition something that can be added to the setup?

Question... at global.scss you can clearly see that a prefix can be set ![Scherm­afbeelding 2024-03-06 om 08 39 58](https://github.com/joomla/joomla-cms/assets/639822/63368e33-9f1a-4daf-8c7b-45c7a6c1eafd) When a prefix is set both link-color and link-hover-color will not...

I have tested this item :white_check_mark: successfully on e0344a0e9f6ae6dfe6cab21e3a924b208ff23a86This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42794.

> > The only difference is that it is rendered by JLayout which allows users to create an override. > > Am I being daft here but you could always...

> Why are you overriding the native bootstrap alert classes. It is doing this sort of thing that causes problems in the first place, I do agree with you. I...

@Hackwar @brianteeman refactor the joomla-alert as I wrote in my comment implies a PR on https://github.com/joomla-projects/custom-elements/tree/c1f118a5c96f382a43b735b46eb7e04e888987ed/src A PR on that repo will not make it to 5.2.x I guess... :-)...

@Hackwar I leave the PR as is without further changes. I do agree with @brianteeman to embrace Bootstrap implementation of alert. This requires a change to https://github.com/joomla-projects/custom-elements/tree/c1f118a5c96f382a43b735b46eb7e04e888987ed/src which is out...

@Hackwar indeed... I am not fixing code over here, just improving it by removing overrides and using custom properties