rustecs icon indicating copy to clipboard operation
rustecs copied to clipboard

Published 20 hours ago • verified publisher icon hannobraun

Remove pub mod around enums

Open mtsr opened this issue 10 years ago • 4 comments

Since enums are now namespaced, the additional pub mod around them can be removed.

mtsr avatar Dec 07 '14 22:12 mtsr

This was based on a misunderstanding, see https://github.com/hannobraun/rustecs/pull/12#issuecomment-66185312.

I'm leaving this open, since is wouldn't hurt to add a comment to that test, to prevent similar misunderstandings in the future.

As always, I'll get to it next time I can allocate some development time to Rustecs. Until then, pull requests are very welcome.

hannobraun avatar Dec 08 '14 20:12 hannobraun

Heh, it's so similar to the old way of namespacing enums that I assumed it was.

mtsr avatar Dec 08 '14 21:12 mtsr

Yeah, now that you brought it up, I see how it's easy to misunderstand :) Again, sorry for your trouble, I completely misunderstood you and initially thought you were referring to something else entirely.

hannobraun avatar Dec 08 '14 21:12 hannobraun

No worries, I'm more than happy to help out. Besides, it's hardly as if this is something I had to spend a lot of time on :).

mtsr avatar Dec 08 '14 21:12 mtsr