inotify-rs

inotify-rs copied to clipboard

Distinguish between events from files with the same name

2

## Describe the issue Hi! While using this API I found myself unable to distinguish between events that arrive from files with the same name yet in different paths. The...

cmosd

As per the the CI configuration, the minimum supported Rust version is 1.47.0: https://github.com/hannobraun/inotify-rs/blob/7d2fc13b275adfe8f08b85bccf9e74a1cc6be83c/.github/workflows/rust.yml#L15 This makes the CI build fail, because the MSRV of Tokio is currently 1.49.0: https://github.com/tokio-rs/tokio#supported-rust-versions Here's...

hannobraun

Consider reverting #146 at some point

3

The compiler [dropped support](https://github.com/rust-lang/rust/issues/62516) for RHEL 5, so #146 can in principle be reverted when the MSRV gets bumped to 1.47.

lnicola

Implement ToOwned for `Event<&'a OsStr>`

4

I am using inotify with calloop and one issue I've noticed is the lack of ability to easily convert an event from the methods into an owned event to pass...

i509VCB

Consider using cargo clippy in test workflows

1

Clippy adds quite a few interesting lints that may be useful to have. At the moment running clippy has 4 errors, mostly redundant field names in initialization. Clippy does also...

i509VCB

Consider unifying traditional and future-based APIs

4

Currently there are two parallel APIs: The original one, and the new future-based one. I think it would be ideal if we could unify those. One problem I see is...

hannobraun

Add a separate `Watches` struct that provides `add` and `remove` methods to replace `Inotify::add_watch`/`Inotify::rm_watch`. It should be possible to get an instance of this struct from `Inotify` and `EventStream` (for...

hannobraun

`Inotify::event_stream` enabled concurrent use of one `Inotify` instance and an arbitrary number of `EventStream` instances, which is error-prone. It should be replaced with an `into_event_stream` method that consumes the `Inotify`....

hannobraun

See #155 and and #171 (specifically https://github.com/hannobraun/inotify-rs/pull/171#pullrequestreview-655632788) for context.

hannobraun

panic when call event_stream

1

panic info: ``` 5: std::panicking::begin_panic at ~/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:505:12 6: tokio::io::driver::Handle::current at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.3.5/src/io/driver/mod.rs:277:13 7: tokio::io::async_fd::AsyncFd::with_interest at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.3.5/src/io/async_fd.rs:99:51 8: tokio::io::async_fd::AsyncFd::new at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/tokio-0.3.5/src/io/async_fd.rs:89:9 9: inotify::stream::EventStream::new at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/inotify-0.9.1/src/stream.rs:35:17 10: inotify::inotify::Inotify::event_stream at ~/.cargo/registry/src/github.com-1ecc6299db9ec823/inotify-0.9.1/src/inotify.rs:406:9 11: controller::sync::Notifier::watch::{{closure}} at...

rink1969