fornjot icon indicating copy to clipboard operation
fornjot copied to clipboard

Exit with error, if user provides unused parameters

Open hannobraun opened this issue 1 year ago • 2 comments

Fornjot models can have parameters. The user can pass those to the app via the command-line interface, using --parameters.

If the user passes any parameters that the model doesn't use, maybe because of a typo or because the model has changed since the user last used it, that parameter is ignored. This is quite error-prone.

If the user passes a parameter that the model doesn't use, this should cause the app to exit with an appropriate error message. Detecting this requires a better interface between host and model. See #804, which this issue is currently blocked on.

hannobraun avatar Jul 15 '22 09:07 hannobraun

The metadata system mentioned in https://github.com/hannobraun/Fornjot/issues/804#issuecomment-1193139276 would be quite useful here.

Michael-F-Bryan avatar Jul 23 '22 15:07 Michael-F-Bryan

#804 has been addressed. This is no longer blocked.

hannobraun avatar Aug 12 '22 10:08 hannobraun

This issue is no longer applicable. The affected code has been removed. See A New Direction for context.

hannobraun avatar May 15 '23 09:05 hannobraun