Hanno Braun

Results 489 comments of Hanno Braun

@ryankurte > the SPI traits are currently generic over `W` allowing implementations to define supported word sizes (though in practice I haven't seen any non-`u8` implementations yet). Here: https://github.com/stm32-rs/stm32f7xx-hal/blob/master/src/spi.rs Specifically:...

Thank you for opening this issue, @droogmic. I agree with your interpretation, and the timer restarting is certainly the most sensible actions for the uses cases that I've seen so...

@justacec More DMA implementations keep appearing. I've personally worked on two ([`stm32f7xx-hal`](https://github.com/stm32-rs/stm32f7xx-hal/blob/master/src/dma.rs), [`stm32l0xx-hal`](https://github.com/stm32-rs/stm32l0xx-hal/pull/14)) over the last weeks. I'm not aware of any efforts for creating a platform-independent API that could...

@japaric Did you add the `needs-impl` tag on purpose? It doesn't seem to apply, since the trait has a default implementation. Or do you want to see alternative implementations that...

> The default implementation is opt in. I still think it should be checked that the default implementation works on hardware. Ah, that makes sense. I'm [using the default implementation](https://github.com/braun-robotics/rust-lpc82x-hal/blob/c475f38d3322bb2adeabd572ff2408ee27ac7d97/src/usart.rs#L285)...

I agree with your conclusion that taking a `Hertz` value directly would be better and less confusing. The conversion to `embedded-time` was a rather minimally invasive procedure, and I didn't...

@hellow554 > When I have time in a few weeks, I'll try to resolve these, but feel free to do it in the meantime. I don't have the time to...

No, as of now both are not supported.

Was `device` a re-export of the PAC (the `stm32f7` crate)? If so, this is now available as `pac`. The HAL itself doesn't seem to have ADC support.

The `stm32f7` crate supports the whole STM32F7 series, which consists of several product lines, like STM32F7x3, STM32F7x9, and so forth. Those modules in `stm32f7` correspond to those product lines, and...