SkyHanni icon indicating copy to clipboard operation
SkyHanni copied to clipboard

Improvement: Item Ability Rewrite

Open hannibal002 opened this issue 1 year ago • 8 comments

Goal

Scrap all existing detection logics for Item Ability Cooldowns (chat, action bar, sound, particles) and only use item right/left click for everything

Edit: this pr is ready as is. the mana features will be part of another pr.

Changelog Improvements

  • Hide ability cooldowns when the item can not be used. - hannibal2

hannibal002 avatar Feb 10 '24 22:02 hannibal002

Restored PR comment

Some code improvemenst and a lot of cases where the it doesn't work. Also some missing abilities, that probably should be added for completeness sake.

  • Might be a good idea to add a separate duration to the ItemAbility.
  • Not enough mana breaks the feature.
  • Shows ready display for 0 cooldown items (eg. Aspect of the end)
  • Abilitys that have issues (not a complete list, only the items I tested and found a problem):
  • [ ] Voodoo Doll (both normal and jinxed), since cooldown only applies when hit (so when the chatmessage "§cNo target found!" countes as a valid cast)
  • [ ] Wand of Atonement (and probably all other healing wands) can be recasted after 1 seconds so the "cooldown" should update
  • [ ] Fire Veil - same as Wand of Atonement but the particle hider also breaks if casted again inbetween the cooldown
  • [ ] Dreadlordsword is missing (has no cooldown but for the abilitycastevent)
  • [ ] Conjuring missing (but get's complicated since even hypixel don't know what to do with it)
  • [ ] Flower of Truth, the error bugs out the cooldown : "§cYou need to have at least 10% of your health remaining to use this item!"
  • [ ] Arorora Stuff, item not detected
  • [ ] Aspect of the Dragon, missing
  • [ ] Leaping Sword / Silk-Edge Sword, missing
  • [ ] Rogue Sword, same issue as Wand of Atonement
  • [ ] Staff of the Rising Sun, missing
  • [ ] End Stone Bow, missing (idk, but probably should be added for completeness sake)
  • [ ] Machine Gun Bow, missing

Thunderblade73 avatar Feb 11 '24 21:02 Thunderblade73

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Feb 16 '24 10:02 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Feb 16 '24 10:02 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Feb 19 '24 12:02 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Feb 24 '24 19:02 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Mar 12 '24 19:03 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Mar 14 '24 11:03 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Mar 21 '24 15:03 github-actions[bot]