hannibal002
Backend + Improvement: Forge Key Events
What
Before we just used the last Keyboard.Event each tick to read our inputs. Now we're connected to the normal way of doing this. We use forge events, that means on KeyInputEvent we go and check the keyboard for the event, this is done for all events, tho it's controlled by forge. Same principal applies to the mouse.
Tested cases
- Keyboard keybinds
- Mouse keybinds
- Without a mouse plugged in
Changelog Improvements
- Keybinds now work when pressing multiple keys at the same time. - rueblimaster
Changelog Technical Details
- Switched over to forge events to power KeyEvents. - rueblimaster
3 Detekt Failures were detected:
- FishingTimer.kt#L31: Unused import
-
KeyboardManager.kt#L22: Private property
lastClickedMouseButtonis unused. - KeyboardManager.kt#L22: Variable 'lastClickedMouseButton' could be val.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
There is a 0% chance we're touching this file again
I heard David wants to durability test the new system. Go ahead @DavidArthurCole
There is a 0% chance we're touching this file again
I heard David wants to durability test the new system. Go ahead @DavidArthurCole
Yeah sure give me til 2040
2 Detekt Failures were detected:
- KeyStateManager.kt#L10: Unused import
- KeyStateManager.kt#L14: Unused import
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
1 Detekt Failure was detected:
- KeyStateManager.kt#L4: Imports begin with a pre-processed comment, make sure to check the order of the imports. If this pre-processing comment is correct you can baseline this error. If you did accidentally change the order of the imports fix them.
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
1 Detekt Failure
-
ForgeKeyStateManager.kt#L4
PreprocessingImportOrdering: Imports begin with a pre-processed comment, make sure to check the order of the imports. If this pre-processing comment is correct you can baseline this error. If you did accidentally change the order of the imports fix them.
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
I think its just easier if we drop 1.8 support instead of worrying about any small issues in the 1.8 keybind system
