Backend: Keybindings
Dependencies
- #3871
What
Describe what this pull request does, including technical details, screenshots, links to discord, etc.
Images
Changelog Technical Details
- Added Keybinding to simplify keybindings. - rueblimaster
I'd rather see an key up event that also includes the "last key up of same key duration" as a parameter
I see you copied the approach for the inventory render helper here. But I'm not sure I like this solution for keybinds
only going to be done after
- https://github.com/hannibal002/SkyHanni/pull/3871
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
Conflicts have been resolved! 🎉
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
Conflicts have been resolved! 🎉
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
Conflicts have been resolved! 🎉
Have not looked through this pr yet but I would like this to not be merged before we have a working 1.21 version. As i dont want to debug completely new code after already changing a bunch of stuff to get key events to work on 1.21. Merging this will just mean there is more uncertainty as to what broke key events and will slow down fixing it as well. I will take it off soon but it can probably be re-added in a day or two
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
Conflicts have been resolved! 🎉
Have not looked through this pr yet but I would like this to not be merged before we have a working 1.21 version. As i dont want to debug completely new code after already changing a bunch of stuff to get key events to work on 1.21. Merging this will just mean there is more uncertainty as to what broke key events and will slow down fixing it as well. I will take it off soon but it can probably be re-added in a day or two
This doesn't change the key events in any way or form, only the dependency does
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
Conflicts have been resolved! 🎉
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.
Conflicts have been resolved! 🎉
This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.