SkyHanni icon indicating copy to clipboard operation
SkyHanni copied to clipboard

Backend: Keybindings

Open rueblimaster opened this issue 1 year ago • 19 comments

Dependencies

  • #3871

What

Describe what this pull request does, including technical details, screenshots, links to discord, etc.

Images

Changelog Technical Details

  • Added Keybinding to simplify keybindings. - rueblimaster

rueblimaster avatar Apr 21 '25 15:04 rueblimaster

1 Detekt Failure was detected:

github-actions[bot] avatar Apr 21 '25 15:04 github-actions[bot]

I'd rather see an key up event that also includes the "last key up of same key duration" as a parameter

I see you copied the approach for the inventory render helper here. But I'm not sure I like this solution for keybinds

hannibal002 avatar Apr 22 '25 06:04 hannibal002

only going to be done after

  • https://github.com/hannibal002/SkyHanni/pull/3871

rueblimaster avatar Apr 24 '25 19:04 rueblimaster

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Apr 30 '25 20:04 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar May 13 '25 19:05 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Jun 06 '25 12:06 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Jun 07 '25 17:06 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Jun 19 '25 11:06 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Jun 20 '25 12:06 github-actions[bot]

Have not looked through this pr yet but I would like this to not be merged before we have a working 1.21 version. As i dont want to debug completely new code after already changing a bunch of stuff to get key events to work on 1.21. Merging this will just mean there is more uncertainty as to what broke key events and will slow down fixing it as well. I will take it off soon but it can probably be re-added in a day or two

CalMWolfs avatar Jun 21 '25 04:06 CalMWolfs

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Jun 21 '25 12:06 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Jun 28 '25 15:06 github-actions[bot]

1 Detekt Failure was detected:

github-actions[bot] avatar Jun 28 '25 15:06 github-actions[bot]

Have not looked through this pr yet but I would like this to not be merged before we have a working 1.21 version. As i dont want to debug completely new code after already changing a bunch of stuff to get key events to work on 1.21. Merging this will just mean there is more uncertainty as to what broke key events and will slow down fixing it as well. I will take it off soon but it can probably be re-added in a day or two

This doesn't change the key events in any way or form, only the dependency does

rueblimaster avatar Jun 28 '25 16:06 rueblimaster

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Jul 12 '25 03:07 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Aug 02 '25 15:08 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Sep 17 '25 09:09 github-actions[bot]

Conflicts have been resolved! 🎉

github-actions[bot] avatar Sep 23 '25 16:09 github-actions[bot]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

github-actions[bot] avatar Nov 14 '25 04:11 github-actions[bot]