Feature: Mining Notifications v2

[martimavocado]

Dependencies

• #1059
• https://github.com/Thunderblade73/SkyHanni/pull/3

What

Adds a few more mining notifications:

• Pickaxe Ability Ready
• Pickaxe Ability Used
• Pickaxe Ability Expired
• Commission completed

Removed the Mineshaft Spawned notification since hypixel added it. Currently the pickaxe ready notification is a bit inaccurate, since it doesn't check for the skymall or mineshaft mayhem perks. fix soon™

Changelog Improvements

• Added new Mining Notifications. - martimavocado
  • This includes Pickaxe Ability Ready, Used and Expired, and Commission completed.

Changelog Removed Features

• Removed Mineshaft Spawned from Mining Notifications. - martimavocado

[martimavocado]

Code lgtm, though I do think at this point using a bunch of marchers in the when statement is getting a bit excessive especially because a few of them now need to create a matcher a second time after calling .matches

yeah that's fair, any better ideas?

[CalMWolfs]

yeah that's fair, any better ideas?

Not really, you could make the ones that actually need the matcher to be outside of the when and use matchmatcher for those then have a return at the end of each and then leave all the .matches inside the when

[jani270]

Is there a reason that you dont just use: Mining Speed Boost is now available! ?

[martimavocado]

Is there a reason that you dont just use: Mining Speed Boost is now available! ?

~~some people sweat having multiple abilities at once~~ oh wait you mean the rundelayed, the reason is the chat message is slightly delayed

[github-actions[bot]]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions[bot]]

Conflicts have been resolved! 🎉

[github-actions[bot]]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[github-actions[bot]]

Conflicts have been resolved! 🎉

[Thunderblade73]

Hannibal this has an old version of the hotmAPI. Therefore please commit to the HotmApi Pr for changes or else it will get convoluted and double the work.

[github-actions[bot]]

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

[Thunderblade73]

To fix the merge conflict merge hotmAPI into it