qvitter
qvitter copied to clipboard
hannesmannerheim
Right-To-Left UI Support
I can happily contribute to that since it's my daily job already on Firefox OS. Will look at it this weekend.
would be great if you did! once there were full rtl support in qvitter, but with changes it has been forgotten about. it is mostly tedious css work. rtl-styles are currently spread out in the whole of css/qvitter.css....
when the user selects a rtl language the body element gets an rtl-class.
there's also automatic detecting of rtl queets. those queets get an rtl-class.
the biggest thing right now seems to be that the header is messed up, and the "queetbox" where you write queets is completely crazy. but there's probably more :)
My approach on this would be
1- When an RTL language is detected, set a dir="rtl" in the <html> tag instead of setting a custom class to th body.
2- Use html[dir="rtl"] for all the rtl-specific rules
3- rework everything-RTL css from the ground up
4- Group all the RTL rules at the bottom of the file/files so they are easier to find and maintain
i tried adding the RTL attribute to the html tag now. it makes all non-rtl queets turn RTL. i would prefer if LTR queets were always LTR and RTL queets were always RTL, no matter what the direction of the rest of the UI is.
Sure :) I was talking about the rest of the UI. But of course single inputs get treated based on their content, not page direction.