libmergepdf icon indicating copy to clipboard operation
libmergepdf copied to clipboard

Fix wrong return to prevent infinity loop

Open vitormattos opened this issue 2 years ago • 7 comments

vitormattos avatar Nov 28 '21 11:11 vitormattos

Seems to be valid, but no time for testing

kaystrobach avatar Nov 28 '21 11:11 kaystrobach

Without this change using specific PDF files the code enter on a infinity loop. Don't is possible test with any PDF files. I tested and worked fine for me.

vitormattos avatar Nov 28 '21 17:11 vitormattos

Hi,

Can we close this?

floviolleau avatar Jan 10 '24 10:01 floviolleau

Without merge ?

floviolleau avatar Jan 10 '24 10:01 floviolleau

you asked for closing it.

kaystrobach avatar Jan 10 '24 11:01 kaystrobach

My mistake, I was asking to merge and finish this PR to close the subject

floviolleau avatar Jan 10 '24 13:01 floviolleau

Have no test for it, feel unsure about mergin it. Can you provide an example file, which ends up in an infinite loop?

kaystrobach avatar Jan 10 '24 14:01 kaystrobach