Hannan Komari
Hannan Komari
@sanchit-gandhi Have you reviewed my added test codes?
> Hi @hannan72, thanks for raising an issue! > > Questions like this should be asked in the [forum](https://discuss.huggingface.co/) as we try to reserve github issues for bugs and specific...
> Hi @hannan72! I recommend that you use Optimum for exporting Whisper to the ONNX format (it will basically be a wrapper around `torch.onnx.export` but it is tested and Whisper...
Hi, Could you please share the training scripts? Also could you please share the link to the training data?
Any updates @sanchit-gandhi @ArthurZucker ?
I think the error is due to the issue of checking jax arrays with `not` in `tokenization_whisper.py` code: https://github.com/huggingface/transformers/blob/d1f39c484d8347aa7b3170ea250a1e8f3bdfdf31/src/transformers/models/whisper/tokenization_whisper.py#L852  It is OK to check `token_ids` if it is torch...
I created a PR: https://github.com/huggingface/transformers/pull/33151 @ArthurZucker Please review and merge it
Any other points @amyeroberts ?
Is it ready to merge @amyeroberts?
@amyeroberts Test codes has been added and passed by automatic tests. Code you please do the final review?