Michael Han

Results 33 comments of Michael Han

@karanmehta93 Thanks for update the pull request with more context information. Do you mind put the context description in the pull request description? Regarding test cases, I think you can...

I think we should consolidate the latency check in `zks.serverStats().updateLatency`. It's odd to have two (or in future even more) types of latency checks scattered around which creates fragmentation w.r.t....

>> And for the documentation, this property is being introduced from 3.5.4 version, Is that correct? Yes, for this specific pull request targeting master. I think at some point after...

There are -1 on findbugs, release audits, and test failures reported by Jekins. Please investigate.

looks like the branch has merge conflicts. do you mind update your patch with latest master and I'll review @karanmehta93

#1380 landed so this one is good to go. "just" need a rebase and fixing check style errors @lvfangmin

> Great work. > I left a few code style comments, please take a look. > > Also can you please follow up with a documentation update? Thanks for review,...

>> What are the large number of THREAD_SAFETY violations from muse-dev bot? These are reports generated by the static analysis tool used by the bot. Some of these are false...

Rebase patch with latest master to resolve merge conflicts. I will have another pass to see what to do with the musedev bot.

> @hanm I'm one of the developers of Muse bot and am watching this play out. If, at the end of the day, you have thoughts or opinions then we're...