Hank Jacobs

Results 14 comments of Hank Jacobs

Thanks! My only preference is that it be incremental to avoid huge PRs.

Hi @larkin-nz, The goal of cloudworker is to match the behavior of Cloudflare Workers as best as possible. In the example you cited, `a instanceof Object` would return true within...

This seems very specific to your use of cloudworker. The reason I added the code to handle objects coming from the runtime realm is that without it using `instanceof` against...

Hi @markusahlstrand, I don't understand the question. Could you give specific examples of what you are trying to accomplish and why it currently doesn't work? Thanks!

I’m pretty sure this has to do with an architectural issue I discuss [here](https://github.com/dollarshaveclub/cloudworker/pull/81#issuecomment-485292676) and [improvements I made](https://github.com/dollarshaveclub/cloudworker/pull/85) in an attempt to make the corners less sharp. It has to...

Thanks but it appears that this broke the hmac e2e gets

So this exposed a fundamental flaw with the way things are architected. The TLDR is that libraries used by worker scripts (e.g. anything loaded via the Context) can't used `instanceof`...

A simplified example of the problem can be seen by running: ``` vm.runInNewContext("test = {}; test instanceof Object", {Object:Object}) ``` The above returns false when it should return true.

Here's a better example of the issue. `comp` returns false when it should return true (at least it should for the new crypto library to function properly). ``` vm.runInNewContext("comp({})", {comp:...