hangy

Results 90 comments of hangy

Sorry, I must've misread. In that case, robotoff shouldn't replace the separators. > I like the idea of normalizing to ISO 8601, but the format will be inconsistent between robotoff-...

> Yes indeed, as I said above robotoff matches dates of format `dd.mm.yyyy` In https://de.openfoodfacts.org/produkt/4311501619872/harzer-minis-gut-gunstig?rev=20 the expiration date was updated to `06/07/2019` based on the text `06.07.19` in this image:...

> I've fixed the normalization issue by normalizing dates to ISO 8601 in [836b4eb](https://github.com/openfoodfacts/robotoff/commit/836b4eb82a832498b29f676d917f58ba1c26a13f). Looks good, thank you! > Regarding the other issue you mention, I think we could change...

Hi @davidkarlsen, is there anything else you need to bump the image version? I noticed there was a similar PR #218 for the previous patch release. Thanks in advance! 😄

More potentials: https://github.com/search?q=repo%3Aopenfoodfacts%2Fopenfoodfacts-server%20path%3A*.tt.js&type=code

> Finally, I Think we might use **pure HTML rather than Javascript**, see: https://www.w3schools.com/tags/att_global_accesskey.asp 👍 Much better for accessibility reasons than a custom JS-only solution. About the shortcuts to use:...

> > This is mostly done, although I noticed the devcontainer.json is still mentioning redis and mongodb so assume this might need some changes to cater for shared-services. @alexgarel, @stephanegigandet...

That seems to be correct, according to the specs: https://github.com/openfoodfacts/openfoodfacts-server/blob/25d4175330f9fadbba8bc80ec0afea358a9b4c3d/lib/ProductOpener/Food.pm#L4397-L4421