next-offline icon indicating copy to clipboard operation
next-offline copied to clipboard

next-offline - a configuration is needed for nextAssetDirectory variable

Open vkavoun opened this issue 4 years ago • 1 comments

Hello I am working on implementing serviceWorkers in NRWL monorepo ecosystem with typescript.

The issue at hand is that the are several hardcoded paths. image

So far most of the issues can be resolved by configuring next.config.js but the static folder is not.

I am going to modify the module for my needs and I will open a PR with the option to configure the static folder location.

Thanks. Vlad

🎉 Thanks for taking the time to contribute to next-offline!

It is highly appreciated that you take the time to help improve next-offline. We appreciate it if you would take the time to write up a bug report or feature request.

Sadly, if we don't receive enough information, or the issue/feature request doesn't align well with our roadmap, we might respectfull thank you for your time, and close the issue.

Bug fixes and documentation fixes are welcome.

In the case of a bug report 🐞

Please consider the following items when filing a bug report:

  • Issue and steps to reproduce.
  • Versions.
  • Screenshots.
  • Expected.
  • Actual.
  • Link to your project.
  • Browser name and version.

In the case of a feature/component request ✍️

Please consider the following items when filing a feature request:

  • Usage, component API if applicable.
  • Design Example, screenshot of what the design should look like.
  • Problem that feature addresses.

See the contributing guide for more details.

Respect earns Respect 👏

Please respect our Code of Conduct, in short:

  • Using welcoming and inclusive language.
  • Being respectful of differing viewpoints and experiences.
  • Gracefully accepting constructive criticism.
  • Focusing on what is best for the community.
  • Showing empathy towards other community members.

vkavoun avatar Apr 05 '20 19:04 vkavoun

Hello I am working on implementing serviceWorkers in NRWL monorepo ecosystem with typescript.

The issue at hand is that the are several hardcoded paths. image

So far most of the issues can be resolved by configuring next.config.js but the static folder is not.

I am going to modify the module for my needs and I will open a PR with the option to configure the static folder location.

Thanks. Vlad

🎉 Thanks for taking the time to contribute to next-offline!

It is highly appreciated that you take the time to help improve next-offline. We appreciate it if you would take the time to write up a bug report or feature request.

Sadly, if we don't receive enough information, or the issue/feature request doesn't align well with our roadmap, we might respectfull thank you for your time, and close the issue.

Bug fixes and documentation fixes are welcome.

In the case of a bug report 🐞

Please consider the following items when filing a bug report:

  • Issue and steps to reproduce.
  • Versions.
  • Screenshots.
  • Expected.
  • Actual.
  • Link to your project.
  • Browser name and version.

In the case of a feature/component request ✍️

Please consider the following items when filing a feature request:

  • Usage, component API if applicable.
  • Design Example, screenshot of what the design should look like.
  • Problem that feature addresses.

See the contributing guide for more details.

Respect earns Respect 👏

Please respect our Code of Conduct, in short:

  • Using welcoming and inclusive language.
  • Being respectful of differing viewpoints and experiences.
  • Gracefully accepting constructive criticism.
  • Focusing on what is best for the community.
  • Showing empathy towards other community members.

I have fixed this and updated with latest nextjs version https://github.com/meabed/next-offline-ts

meabed avatar Dec 11 '21 17:12 meabed