Hanefi Onaldi

Results 37 comments of Hanefi Onaldi

I suggest you rebase your changes on top of #5561 that parameterized PG versions in CircleCI config. This will make your changes easier to read.

Here is the failure diff on my local: ```diff diff --git a/src/test/regress/expected/citus_split_shard_columnar_partitioned.out b/src/test/regress/expected/citus_split_shard_columnar_partitioned.out index b1cebc392..5a599231e 100644 --- a/src/test/regress/expected/citus_split_shard_columnar_partitioned.out +++ b/src/test/regress/expected/citus_split_shard_columnar_partitioned.out @@ -556,8 +556,8 @@ SET citus.shard_replication_factor TO 1; 8999120 |...

The newly introduced vendor library license (`vendor/libbacktrace/LICENSE`) need to be included in the packages. We will need to make some changes in the packaging repository similar to this https://github.com/citusdata/packaging/pull/504

Jelte and I had a brief discussion and dismissed the idea to have alternative test outputs in https://github.com/citusdata/citus/pull/4004#discussion_r452700499 However, we can still do that. I suggest we wait until we...

I was not able to reproduce the first error message yet, but I see the second error messages. The second problem occurs when you upgrade to `>=10.2-4` and try to...

I have opened a PR that fixes the second error message shared in this issue. I still fail to reproduce the first one. However, I can already think of a...

> After installing 10.2 with the install-downgrades from main, I get the following error: > > ``` > postgres=# alter extension citus update; > ERROR: cache lookup failed for pg_dist_object,...

Closing this one as Jelte merged better alternatives already

We merged #5842 and it might make sense to drop CI configs for PG12 after a rebase or merge

There are two issues raised by CodeQL now. We are aware of the possibility of the race condition, and it is safe to ignore those as it is actually a...