Try to fix rewrite for self file extension method [Workaround]

[builder-main]

Hi, let's try to make a rewriter for extension methods. It would allow to avoid ambiguous call compilation errors :

public static class SomeClass {

  public static void MyExtension(this string myString){  ... }

  public static void MyMethod(){  "someValue".MyExtension() } //Will cause an ambiguous call in the compiler

  public static void MyMethod(){  MyExtension("someValue") } //This works and is the current workaround.
}

[handzlikchris]

Thanks - I think extensions are also part of other feature. Off top of my head there were some more issues with that unfortunately.

I think especially for rewritten code where YourType would end up YourType__Patched_ and extension method will complain.

We could probably cast it to (ProperType)(dynamic)variable. That's a hack for compiler as your variable is still of old type, same approach is used for something else already (I think for 'this' rewritting)

[BillDong2021]

Is it not possible for rewriting extension methods yet now? Currently I’m working with one ECS framework of Unity, and it uses extension method almost everywhere :(

[handzlikchris]

sorry, I've not had a chance to get to it. I could point you in the right direction if you want to give that a try

[builder-main]

Is it not possible for rewriting extension methods yet now? Currently I’m working with one ECS framework of Unity, and it uses extension method almost everywhere :(

There is the workaround in the meantime with classical static method syntax. Making a specific rewriter is a feasible task even for newcomers, you could look at the examples and try make a PR if this is a subject that is bothering you a lot.