hyperformula
hyperformula copied to clipboard
information plugin has incorrect `optional: true` argument
export class InformationPlugin extends FunctionPlugin implements FunctionPluginTypecheck<InformationPlugin> {
public static implementedFunctions = {
'COLUMN': {
method: 'column',
parameters: [
{argumentType: ArgumentTypes.NOERROR, optional: true}
],
isDependentOnSheetStructureChange: true,
doesNotNeedArgumentsToBeComputed: true,
vectorizationForbidden: true,
},
optional:true -> optionalArg: true
Same bug is also on the 'ROW' Function.
optional isn't an actually doing anything here
Test descriptions are also wrong for it:
it('should take one or zero arguments', () => {
const [engine] = HyperFormula.buildFromArray({ cells: [
[{ cellValue: '=COLUMN(B1, B2)' }],
[{ cellValue: '=COLUMN(B1, B2, B3)' }],
]})
I am sorry you experienced an issue with HyperFormula. Our team will investigate it.
PR submitted with proposed fix - https://github.com/handsontable/hyperformula/pull/1227
@MartinDawson this issue is fixed in HyperFormula 2.4.0. @thilgen thank you for helping us with that ;)