hyperformula icon indicating copy to clipboard operation
hyperformula copied to clipboard

information plugin has incorrect `optional: true` argument

Open MartinDawson opened this issue 3 years ago • 1 comments

export class InformationPlugin extends FunctionPlugin implements FunctionPluginTypecheck<InformationPlugin> {
  public static implementedFunctions = {
    'COLUMN': {
      method: 'column',
      parameters: [
        {argumentType: ArgumentTypes.NOERROR, optional: true}
      ],
      isDependentOnSheetStructureChange: true,
      doesNotNeedArgumentsToBeComputed: true,
      vectorizationForbidden: true,
    },

optional:true -> optionalArg: true

Same bug is also on the 'ROW' Function.

optional isn't an actually doing anything here

Test descriptions are also wrong for it:

it('should take one or zero arguments', () => {
    const [engine] = HyperFormula.buildFromArray({ cells: [
      [{ cellValue: '=COLUMN(B1, B2)' }],
      [{ cellValue: '=COLUMN(B1, B2, B3)' }],
    ]})

MartinDawson avatar Jan 16 '22 10:01 MartinDawson

I am sorry you experienced an issue with HyperFormula. Our team will investigate it.

sequba avatar Apr 26 '22 11:04 sequba

PR submitted with proposed fix - https://github.com/handsontable/hyperformula/pull/1227

thilgen avatar Apr 03 '23 23:04 thilgen

@MartinDawson this issue is fixed in HyperFormula 2.4.0. @thilgen thank you for helping us with that ;)

sequba avatar Apr 24 '23 12:04 sequba