hyperformula icon indicating copy to clipboard operation
hyperformula copied to clipboard

Add cellAddress to "Value of the formula cell is not computed." error message

Open wojciechczerniak opened this issue 4 years ago • 2 comments

Description

We should add a cell address to the error message so we can trace the source of this error more easily.

https://github.com/handsontable/hyperformula/blob/508e4e4d9961473a35686354f46e3162be2cd53e/src/DependencyGraph/FormulaCellVertex.ts#L74

A simple JSON.stringify should do. ie:

throw Error(`Value of the formula cell is not computed for: ${JSON.stringify(this.cellAddress)}`)

TODO:

  • [ ] Add this.cellAddress to the error message
  • [ ] Check if this.formula will be usefull here as well
  • [ ] Check if this.cellAddress should be better formatted than stringify

wojciechczerniak avatar Jul 07 '20 20:07 wojciechczerniak

@wojciechczerniak: Could you add an example of how to get this error?

mrpiotr-dev avatar Jul 15 '20 18:07 mrpiotr-dev

@swistach Unfortunately, it's not that easy. All known reasons for this error are fixed. There are some tests here: https://github.com/handsontable/hyperformula/pull/446/files but you would have to go back to the revision before to test it.

wojciechczerniak avatar Jul 15 '20 19:07 wojciechczerniak