hyperformula icon indicating copy to clipboard operation
hyperformula copied to clipboard

Add unit test for `moveColumns` with tight `maxColumns` limit

Open sequba opened this issue 2 years ago • 1 comments

Context

TBP

How did you test your changes?

TBP

Types of changes

  • [ ] Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • [ ] New feature or improvement (a non-breaking change that adds functionality)
  • [ ] Bug fix (a non-breaking change that fixes an issue)
  • [ ] Additional language file, or a change to an existing language file (translations)
  • [ ] Change to the documentation

Related issues:

#1185

Checklist:

  • [ ] My change is compliant with the OpenDocument standard.
  • [ ] My change is compatible with Microsoft Excel.
  • [ ] My change is compatible with Google Sheets.
  • [ ] My code follows the code style of this project.
  • [ ] I described my changes in the CHANGELOG.md file.
  • [ ] My changes require a documentation update.
  • [ ] My changes require a migration guide.

sequba avatar Mar 14 '23 13:03 sequba

Performance comparison of head (30db0f3aa898976953283f2047470e9d716b99ae) vs base (bc23b9812c4bf22933b8125bb68a5ed9c91b4a5b)

                                     testName |  base |  head |  change
-----------------------------------------------------------------------
                                      Sheet A | 618.5 | 637.5 |  +3.07%
                                      Sheet B | 269.3 | 270.6 |  +0.48%
                                      Sheet T |   309 | 316.9 |  +2.56%
                                Column ranges | 733.1 | 762.5 |  +4.01%
Sheet A:  change value, add/remove row/column |    40 |    44 | +10.00%
 Sheet B: change value, add/remove row/column |   350 |   357 |  +2.00%
                   Column ranges - add column |   272 |   260 |  -4.41%
                Column ranges - without batch |   712 |   591 | -16.99%
                        Column ranges - batch |   380 |   182 | -52.11%

github-actions[bot] avatar Mar 14 '23 13:03 github-actions[bot]