hyperformula icon indicating copy to clipboard operation
hyperformula copied to clipboard

Add unit tests for addColumns with various address mapping policies

Open sequba opened this issue 3 years ago • 1 comments

Context

TBP

How has this been tested?

TBP

Types of changes

  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] New feature or improvement (non-breaking change which adds functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Additional language file or change to the existing one (translations)
  • [ ] Change to the documentation

Related issues:

  1. #1027

Checklist:

  • [ ] My code follows the code style of this project.
  • [ ] I described the modification in the CHANGELOG.md file.
  • [ ] My change requires a change to the documentation.
  • [ ] My change requires a migration guide.

sequba avatar Jul 11 '22 11:07 sequba

Performance comparison of head (1b9d4b9a8a096546c599dab0970085b41d7875c1) vs base (419d7763474f53496b9c0dcc8e5df2236df7514f)

                                     testName |  base |  head |   change
------------------------------------------------------------------------
                                      Sheet A | 601.3 | 592.9 |   -1.40%
                                      Sheet B | 252.3 | 255.9 |   +1.43%
                                      Sheet T | 296.8 | 283.3 |   -4.55%
                                Column ranges | 619.8 | 663.1 |   +6.99%
Sheet A:  change value, add/remove row/column |    34 |    38 |  +11.76%
 Sheet B: change value, add/remove row/column |   333 |   367 |  +10.21%
                   Column ranges - add column |   199 |   435 | +118.59%
                Column ranges - without batch |   706 |   624 |  -11.61%
                        Column ranges - batch |   187 |   332 |  +77.54%

github-actions[bot] avatar Apr 19 '23 09:04 github-actions[bot]